Ticket #317 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

Find a way around the popup blockers for print module

Reported by: pvalsecc Owned by: pvalsecc
Priority: blocker Milestone: 1.1 Release
Component: Print.client Version: SVN
Keywords: Cc:
State: Commit

Description

Most people have their popup blockers enabled by default. The "Use this url to download your document" is a bit annoying and frightening for the beta user.

Attachments

popup.patch (16.7 kB) - added by pvalsecc 6 years ago.

Change History

Changed 6 years ago by pvalsecc

  • status changed from new to assigned
  • state set to Review

The attached patch works painlessly (click the button and that's it) for:

  • FF2
  • FF3
  • Safari

On IE6 and IE7, when installed in XP SP2 or newer, the "automatic download" is disabled by default. So for it, we have to show an Ext popup with an OK button that once cliked opens the document.

With Opera, it tends to open the PDF document on the current tab, overwriting the MF application. To avoid that we display an Ext popup and open a new tab when the user clicks on the popup's button.

Changed 6 years ago by pvalsecc

Changed 6 years ago by fredj

  • state changed from Review to Commit

in simple.html line 59, please replace Ext.isIE with Open Layers?.Util.alphaHack() to let IE 7 and above use png images. Yes, they can do this incredible feature ...

The patch looks good (tested on FF 3.1), commit if you think it's ok

Changed 6 years ago by pvalsecc

  • status changed from assigned to closed
  • resolution set to fixed

(In [1359]) Work around for popup blockers r=elemoine (closes #317)

Note: See TracTickets for help on using tickets.