modelchange calls all nodes instead of the changed one only

[bartvde]

Currently the modelchange function loops over all nodes, but since the ext checkchange event passes in the changed node, this can be done much more efficiently.

[bartvde]

patch to only handle the model change for the changed node

[sypasche]

I'm wondering if this could break things in certain situations (in particular if you have a complex custom model, with wms layers split into multiple branches).

In the "this.getRootNode().cascade(function()" loop, we populate the wmsLayers by visiting all the nodes of the model. With this optimization, it only visits the checkedNode, so that the wmsLayers Object is not filled with checked nodes outside of the clicked node.

I'd like to write unit tests for the tree so that this kind of refactoring can be tested more easily.

[bartvde]

I hadn't thought about this use case, good thinking, this will most likely fail with my approach.

[elemoine]

Since Bart's patch isn't valid, I'm changing this ticket's milestone to Future.