Ticket #496 (closed enhancement: fixed)

Opened 14 months ago

Last modified 14 months ago

Protocol.MapFish "bbox" property

Reported by: adube Owned by: bbinet
Priority: minor Milestone: 1.2 Release
Component: framework.client Version: SVN
Keywords: protocol Cc: adube@…
State: Commit

Description (last modified by elemoine) (diff)

New/Changed "bbox" property in Protocol.MapFish

Description of the issue :

While trying to use the mapfish protocol with featureserver instead of mapfish, we ran in one little problem : mapfish server uses 'box' and featureserver uses 'bbox'.

Solution(s) :

  • Have "bbox" as an alias to "box" in mapfish.
  • Change the client code (Protocol.Map Fish?) so that "bbox" is used instead of "box", in this way mapfish would be closer to the featureserver interface.

Comments are welcomed

Attachments

patch-MapFish-496-r2710-A0.diff (3.9 kB) - added by elemoine 14 months ago.
patch-MapFish-496-r2729-A1.diff (3.9 kB) - added by bbinet 14 months ago.

Change History

Changed 14 months ago by elemoine

  Changed 14 months ago by elemoine

  • state set to Review
  • description modified (diff)
  • milestone set to 1.2 Release

  Changed 14 months ago by elemoine

Alexandre, that'd be great if you could test Protocol.MapFish against FeatureServer again, and report back in this ticket. Thanks,

  Changed 14 months ago by adube

Eric, I confirm that the patch resolve the issue. I hope this see theses changes in trunk soon. Thanks a lot.

  Changed 14 months ago by elemoine

  • owner changed from elemoine to bbinet

follow-up: ↓ 6   Changed 14 months ago by bbinet

Eric, what should do mapfish server in case it receives both bbox and box params? Which one should it take into account?

If we choose to give priority on bbox to be closer to the featureserver interface, the patch needs minor update.

in reply to: ↑ 5   Changed 14 months ago by elemoine

Replying to bbinet:

Eric, what should do mapfish server in case it receives both bbox and box params? Which one should it take into account?

I personally don't care. I made "box" have precedence over "bbox" because "box" was there first (sort of backward compatibility)

If we choose to give priority on bbox to be closer to the featureserver interface, the patch needs minor update.

You review you choose ;-) Either way's fine with me.

Changed 14 months ago by bbinet

  Changed 14 months ago by bbinet

  • state changed from Review to Commit

patch-MapFish-496-r2729-A1.diff is minor update to ignore "box" if "bbox" is present instead of overwriting it.

This is also making "bbox" have precedence over "box" because "bbox" has been chosen as default on client side.

If you're ok with this, please commit.

  Changed 14 months ago by elemoine

  • status changed from new to closed
  • resolution set to fixed

(In [2731]) Protocol.Map Fish? "bbox" property, r=bbinet (closes #496)

Note: See TracTickets for help on using tickets.