Support inRange property in layer tree

Here's a different approach to the pb of enabling/disabling nodes in the layerTree. Maybe it's not relevant, but at least, I gave it a try.

I simply added minscale and maxscale attributes to the nodes for which it is useful. Here's some code in Layer Tree?.js that does it :

    /**
     * Updates the tree to enable/disable nodes based on their min/maxscale attributes.
     */
    updateDisabled: function() {
        var mapScale = this.map.getScale();
        this.getRootNode().cascade(function(node) {
            if ((node.attributes.minscale && mapScale<node.attributes.minscale)
                ||(node.attributes.maxscale && mapScale>node.attributes.maxscale))
                node.disable();
            else
                node.enable();
        }, this);
    }

Then, I just added in my app code :

map.events.register('zoomend', map, function(){layerTree.updateDisabled();});

When ticket #66 is fixed, this should be part of Layer Tree? code.

We could use the 'changelayer' event on the map instead because layer visibility has changed. Then, this would be a control that detects that the layer visibility has changed and not only that it is out of range.

Replying to pgiraud:

We could use the 'changelayer' event on the map instead because layer visibility has changed. Then, this would be a control that detects that the layer visibility has changed and not only that it is out of range.

I do not think that this approach allows for enough flexibility.

Let's think of a situation, where you have one OL layer, combining several WMS layers, each of them having different min/maxScale (set by the WMS configuration). Then, you would not be able to grey individual nodes in the layerTree (corresponding to each WMS layer) depending on the current map resolution.

Or, do I miss something ?

Okay, given this particular use case, I know think that this should be addressed in an other ticket. Please don't hesitate to open one, for you WMS sublayers specificity.

I'm still convinced that the changelayer event is the one to use to handle the layers inRange property.

Replying to pgiraud:

Okay, given this particular use case, I now think that this should be addressed in an other ticket. Please don't hesitate to open one, for you WMS sublayers specificity.

Done : http://trac.mapfish.org/trac/mapfish/ticket/114

I'm still convinced that the changelayer event is the one to use to handle the layers inRange property.

Me too :-) Both approaches will be necessary IMO.

I agree with pgiraud that this particular ticket could be addressed by having the layer tree listen to the changelayer map event. But since we don't have a patch for this, I'm bumping the ticket to milestone Future.