Ticket #560 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

print controller doesn't work with Routes 1.12

Reported by: elemoine Owned by: elemoine
Priority: blocker Milestone: framework.server 1.2.1 Release
Component: framework.server Version: SVN
Keywords: Cc:
State: Commit

Description

the print controller uses url_for(action=action) and relies on Route Memory (*). And the defaults of Routes have changed in 1.12 with regards to Route Memory, Route Memory is considered bad practice and is now disabled by default.

(*) http://pylonsbook.com/en/1.1/urls-routing-and-dispatch.html#route-memory

Attachments

patch-server-560-r3385-A0.diff (1.2 kB) - added by elemoine 2 years ago.

Change History

Changed 2 years ago by elemoine

Changed 2 years ago by elemoine

  • state set to Review

patch-server-560-r3385-A0.diff fixes it. The controller name is hardcoded as the user cannot use another name than printer.py for the print controller file, this is because the controller class name is PrinterController.

Please review.

Changed 2 years ago by elemoine

  • component changed from contribs.java-geojson to framework.server

Changed 2 years ago by bbinet

  • state changed from Review to Commit

Looks good to me. Please commit.

Changed 2 years ago by elemoine

  • status changed from new to closed
  • resolution set to fixed

(In [3386]) print controller doesn't work with Routes 1.12, r=bbinet (closes #560)

Note: See TracTickets for help on using tickets.