base MapFish on Pylons 1.0

[elemoine]

summary says it all.

[elemoine]

This is ready for review.

[bbinet]

patch-server-575-A0.diff looks good, but it is funny that you forgot to update Pylons dependency version in setup.py whereas the ticket is named: "base MapFish on Pylons 1.0" ;)

We could also remove GeoAlchemy Geometry argument "dimension=2" since it is the default and does not add much value. Same thing for SqlAlchemy sessionmaker arguments: "autoflush=True", "autocommit=False" are the defaults, see: http://www.sqlalchemy.org/docs/reference/orm/sessions.html#sqlalchemy.orm.sessionmaker

[bbinet]

concerning patch-sample-575-A0.diff, it looks good to me, but I haven't tested mapfishsample application for real. So if it works for you, feel free to commit (after having updated setup.py dependencies with Pylons 1.0).

Just one question: I saw that mapfishsample init_model method contains specific code related to spatial lite connexion: is this code specific to mapfishsample of should it be in MapFish model template? (IMO, I would just document these database specificities somewhere in MapFish documentation).

[elemoine]

(In [3580]) base Map Fish? on Pylons 1.0, r=bbinet (bbinet's review comments taken into account) (closes #575)

[elemoine]

Replying to bbinet:

concerning patch-sample-575-A0.diff, it looks good to me, but I haven't tested mapfishsample application for real. So if it works for you, feel free to commit (after having updated setup.py dependencies with Pylons 1.0). Just one question: I saw that mapfishsample init_model method contains specific code related to spatial lite connexion: is this code specific to mapfishsample of should it be in MapFish model template? (IMO, I would just document these database specificities somewhere in MapFish documentation).

Hi Bruno. Thanks for your review. This is already documented in the MapFish docs, see <http://trac.mapfish.org/trac/mapfish/browser/framework/server/trunk/docs/framework/spatial-databases.txt#L333>.

[fredj]

(In [3613]) remove unneeded directories, model dir is created by pylons (see #575)